Introduce exposed API check#64
Merged
tcharding merged 2 commits intorust-bitcoin:masterfrom Feb 17, 2026
Merged
Conversation
nyonson
force-pushed
the
introduce-api-check
branch
from
f062253 to
f5faebb
Compare
Member
|
Why put it in the lint job instead of separately? |
Merged
nyonson
force-pushed
the
introduce-api-check
branch
from
f5faebb to
f7eca39
Compare
Collaborator
Author
tcharding
reviewed
Feb 17, 2026
justfile
Outdated
|
|
||
| # Update the exposed API files in api/. | ||
| [group('tools')] | ||
| update-api-files: _install-rbmt |
Member
There was a problem hiding this comment.
In rust-bitcoin this is just check-api. Do you think its better like this? If so can we have an alias just uaf that matches just ulf
Collaborator
Author
There was a problem hiding this comment.
Hm, should probably just match rust-bitcoin huh? I was following the pattern in update-lock-files, but doesn't feel as strong a reason.
nyonson
force-pushed
the
introduce-api-check
branch
from
f7eca39 to
6b70a27
Compare
Collaborator
Author
|
6b70a27: rename to |
tcharding
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've appreciated this check over in
rust-bitcoinand think it can help here as well. Initialing the api files in the first commit by runningcargo rbmt api. Added the check to CI by extending the existing Lint job, I don't think we need to go testing the 20 parallel jobs limit anytime soon since these are all pretty quick. Bet let me know if there is a preferred job breakdown.